New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Don't retry security polling too often when it fails #5921

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Nov 7, 2017

Short description

Even if the security polling fails because of a Servfail or DNSSEC validation, there is no reason to retry right away during the next houseKeeping() iteration. On recursor with an important workload, we could end up doing a security polling every second.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Nov 7, 2017

@pieterlexis pieterlexis merged commit 441c246 into PowerDNS:master Nov 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-secpoll-loop branch Nov 7, 2017

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017

@rgacogne rgacogne referenced this pull request Nov 13, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment