Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escaping unusual DNS label octets in DNSName is off by one #6018

Merged
merged 2 commits into from Jan 8, 2018
Merged

escaping unusual DNS label octets in DNSName is off by one #6018

merged 2 commits into from Jan 8, 2018

Conversation

mind04
Copy link
Contributor

@mind04 mind04 commented Nov 28, 2017 •
edited

Closes #6018 (commit is now part of this pull request)

https://tools.ietf.org/html/rfc4343#section-2.1

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 29, 2017
@rgacogne
Add a unit test for the label escape issue fixed in PowerDNS#6018
5958391
@Habbie
Copy link
Member

Habbie commented Jan 8, 2018

@mind04 want to pick up that test from @rgacogne?

@mind04
Copy link
Contributor Author

mind04 commented Jan 8, 2018

@Habbie done

@Habbie Habbie merged commit 8ac1aa3 into PowerDNS:master Jan 8, 2018
@mind04 mind04 deleted the escape branch January 8, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auth defect rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mind04 @Habbie @rgacogne