Skip to content

escaping unusual DNS label octets in DNSName is off by one#6018

Merged
Habbie merged 2 commits intoPowerDNS:masterfrom
mind04:escape
Jan 8, 2018
Merged

escaping unusual DNS label octets in DNSName is off by one#6018
Habbie merged 2 commits intoPowerDNS:masterfrom
mind04:escape

Conversation

@mind04
Copy link
Contributor

@mind04 mind04 commented Nov 28, 2017

Closes #6018 (commit is now part of this pull request)

https://tools.ietf.org/html/rfc4343#section-2.1

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@Habbie
Copy link
Member

Habbie commented Jan 8, 2018

@mind04 want to pick up that test from @rgacogne?

@mind04
Copy link
Contributor Author

mind04 commented Jan 8, 2018

@Habbie done

@Habbie Habbie merged commit 8ac1aa3 into PowerDNS:master Jan 8, 2018
@mind04 mind04 deleted the escape branch January 8, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants