Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: sign CDS/CDNSKEY RRsets with the KSK #6655

Merged
merged 1 commit into from May 29, 2018
Merged

auth: sign CDS/CDNSKEY RRsets with the KSK #6655

merged 1 commit into from May 29, 2018

Conversation

chbruyand
Copy link
Member

Short description

In split key schema (KSK, ZSK), CDS and CDNSKEY RRsets are now signed by both the KSK and ZSK. This fixes #6369 that explains more in details the motivations behind that PR.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@chbruyand chbruyand added this to the auth-4.2.0 milestone May 23, 2018
pieterlexis
pieterlexis approved these changes May 28, 2018
View reviewed changes
Copy link
Contributor

@pieterlexis pieterlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@pieterlexis pieterlexis merged commit cce8a23 into PowerDNS:master May 29, 2018
@chbruyand chbruyand deleted the auth-cds-cdnskey-rrsig branch May 29, 2018 09:29
@chbruyand chbruyand mentioned this pull request Dec 5, 2018
Merged
aerique added a commit to aerique/pdns that referenced this pull request Dec 6, 2018
@aerique
Remove PowerDNS#6655 from major features.
7d41aee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieterlexis pieterlexis pieterlexis approved these changes

Assignees
No one assigned
Labels
auth defect needs review
Projects
None yet
Milestone
auth-4.2.0
Development

Successfully merging this pull request may close these issues.

CDS/CDNSKEY RRSIG
2 participants
@chbruyand @pieterlexis