rec: add bogus ring to make it more easy to detect high profile domains with broken dnssec #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The packet cache unit tests do not compile anymore :'( |
rgacogne
reviewed
Jun 18, 2018
pdns/recpacketcache.cc
Outdated
| t_bogusremotes->push_back(source); | ||
| if(t_bogusqueryring) | ||
| t_bogusqueryring->push_back(make_pair(qname, qtype)); | ||
| } |
There was a problem hiding this comment.
It feels a bit wrong to have this code here, IMHO the packet cache should not have any knowledge of the rings or the requestor's source address. Perhaps this logic could be moved in doProcessUDPQuestion()?
mind04
force-pushed
the
bogus-ring
branch
2 times, most recently
from
ddcf6ae
to
88694a6
Compare
rgacogne
changed the title
rgacogne
requested changes
Jun 20, 2018
| @@ -174,6 +178,7 @@ void RecursorPacketCache::insertResponsePacket(unsigned int tag, uint32_t qhash, | |||
| e.d_ttd = now+ttl; | |||
| e.d_creation = now; | |||
| e.d_tag = tag; | |||
| e.d_vstate = valState; | |||
There was a problem hiding this comment.
We should likely also update the validation state when we replace an existing entry, just above.
… the packet cache
rgacogne
approved these changes
Jun 20, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have: