Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Mark set-ptr as deprecated #7797

Merged
merged 1 commit into from
May 14, 2019
Merged

API: Mark set-ptr as deprecated #7797

merged 1 commit into from
May 14, 2019

Conversation

zeha
Copy link
Collaborator

@zeha zeha commented May 9, 2019

Short description

In #4656 there was some agreement to drop set-ptr, this is the first step.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@zeha zeha added this to the auth-4.2.0-rc2 milestone May 9, 2019
@zeha
Copy link
Collaborator Author

zeha commented May 13, 2019

Rebased to get the new CircleCI integration.

@zeha zeha requested a review from Habbie May 13, 2019 22:52
@Habbie
Copy link
Member

Habbie commented May 14, 2019

@pieterlexis can you check that the logging added in this PR is in line with the bigger logging changes you have done?

@pieterlexis
Copy link
Contributor

can you check that the logging added in this PR is in line with the bigger logging changes you have done?

No complaints.

@Habbie Habbie merged commit 2944ace into PowerDNS:master May 14, 2019
@zeha zeha deleted the setptr-deprecate branch May 14, 2019 14:09
@zerwes zerwes mentioned this pull request Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Habbie Habbie Awaiting requested review from Habbie

Assignees
No one assigned
Labels
auth enhancement rest-api
Projects
None yet
Milestone
auth-4.2.0-rc2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeha @Habbie @pieterlexis