Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Implement ContinueAction() #8117

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@rgacogne
Copy link
Member

commented Jul 23, 2019

Short description

As discussed on the mailing-list 1, this new action makes it possible to use an otherwise terminal action without stopping the rule processing. For example:

addAction(AllRule(), PoolAction("mypool"))
addAction(AllRule(), DisableValidationAction())

would route all incoming queries to the mypool pool, and since the PoolAction() terminates the processing the DisableValidationAction() one would never be applied.
With the new action, it is possible to do:

addAction(AllRule(), ContinueAction(PoolAction("mypool")))
addAction(AllRule(), DisableValidationAction())

This would result in all queries being routed to the mypool pool with the CD flag being set.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added some commits Jul 23, 2019

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jul 23, 2019

return true;
break;
case DNSAction::Action::Drop:
++g_stats.ruleDrop;

This comment has been minimized.

Copy link
@zeha

zeha Jul 23, 2019

Collaborator

will this cause incorrect stats?

This comment has been minimized.

Copy link
@rgacogne

rgacogne Jul 23, 2019

Author Member

If you do ContinueAction(DropAction()) then yes, but IMHO you then deserve it :)

@rgacogne rgacogne merged commit 7fc7689 into PowerDNS:master Aug 5, 2019

26 of 27 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: build-auth Your tests passed on CircleCI!
Details
ci/circleci: build-auth-docs Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist-docs Your tests passed on CircleCI!
Details
ci/circleci: build-recursor Your tests passed on CircleCI!
Details
ci/circleci: build-recursor-docs Your tests passed on CircleCI!
Details
ci/circleci: test-auth-algorithms Your tests passed on CircleCI!
Details
ci/circleci: test-auth-api Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-bind Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gmysql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gpgsql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gsqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-ldap Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-lmdb Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-mydns Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-mssql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-sqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-tinydns Your tests passed on CircleCI!
Details
ci/circleci: test-dnsdist-regression Your tests passed on CircleCI!
Details
ci/circleci: test-ixfrdist-regression Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-api Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-bulk Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-regression Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-continue-action branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.