Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Implement ContinueAction() #8117

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 23, 2019

Short description

As discussed on the mailing-list 1, this new action makes it possible to use an otherwise terminal action without stopping the rule processing. For example:

addAction(AllRule(), PoolAction("mypool"))
addAction(AllRule(), DisableValidationAction())

would route all incoming queries to the mypool pool, and since the PoolAction() terminates the processing the DisableValidationAction() one would never be applied.
With the new action, it is possible to do:

addAction(AllRule(), ContinueAction(PoolAction("mypool")))
addAction(AllRule(), DisableValidationAction())

This would result in all queries being routed to the mypool pool with the CD flag being set.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
return true;
break;
case DNSAction::Action::Drop:
++g_stats.ruleDrop;
Copy link
Collaborator

@zeha zeha Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this cause incorrect stats?

Loading

Copy link
Member Author

@rgacogne rgacogne Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do ContinueAction(DropAction()) then yes, but IMHO you then deserve it :)

Loading

@rgacogne rgacogne merged commit 7fc7689 into PowerDNS:master Aug 5, 2019
27 checks passed
Loading
@rgacogne rgacogne deleted the dnsdist-continue-action branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants