rec: Make threads run until asked to stop. #8521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is safer since the atexit handler is not ran while threads are still active. Also, when using valgrind we get more clean leak reports. Retry if the accidentally merged PowerDNS#8518 that was reverted.
omoerbeek
changed the title
With this (on a short run): ==13452== HEAP SUMMARY: ==13452== in use at exit: 0 bytes in 0 blocks ==13452== total heap usage: 54,657 allocs, 54,657 frees, 14,008,997 bytes allocated
rgacogne
requested changes
Nov 13, 2019
There was a problem hiding this comment.
In theory I quite like this change, but I'm a bit worried we might experience the recursor not exiting for a long time in practice, which might be painful. Let's merge it once we are sure that the initial value of RecursorControlChannel::stop is set and see how it goes.
pdns/rec_channel.cc
Outdated
| @@ -17,6 +17,8 @@ | |||
|
|
|||
| #include "namespaces.hh" | |||
|
|
|||
| volatile sig_atomic_t RecursorControlChannel::stop; | |||
There was a problem hiding this comment.
Is the initial value set somewhere?
There was a problem hiding this comment.
https://en.cppreference.com/w/cpp/language/initialization defines that statics are zero initialized. But it might be better to do it explicitly indeed .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is safer since the atexit handler is not ran while threads are
still active. Also, when using valgrind we get more clean leak reports.
Retry of the accidentally merged #8518 that was reverted.
Short description
Checklist
I have: