Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep a masked network in the Netmask class #8812

Merged
merged 3 commits into from Feb 21, 2020
Merged

Keep a masked network in the Netmask class #8812

merged 3 commits into from Feb 21, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Feb 11, 2020 •
edited by Habbie

Short description

Instead of keeping the non-masked version, and comparing them that way.

Needs a good review and should probably not be merged before #8355.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit 83f2ffc into PowerDNS:master Feb 21, 2020
@rgacogne rgacogne deleted the netmask-compare-masked branch February 21, 2020 08:55
@rgacogne rgacogne mentioned this pull request Mar 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
auth dnsdist rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgacogne @omoerbeek