Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Implement bounded loads for the whashed and wrandom policies #8909

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 6, 2020

Short description

Also make sure that the chashed implementation respects the weights, and properly handle backends that are not available during the bounds computation.

Closes #7387.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just prevent the factors from being set less than 1. Otherwise LGTM!

pdns/dnsdist-lua.cc Outdated Show resolved Hide resolved
Also make sure that the chashed implementation respects the weights,
and properly handle backends that are not available during the
bounds computation.
@rgacogne rgacogne merged commit d3a7004 into PowerDNS:master Mar 12, 2020
@rgacogne rgacogne deleted the ddist-bounded-load-weight branch March 12, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist needs a 'bounded hashing' server selection policy
2 participants