auth: add support for dnssec removal to CDS/CDNSKEY #9631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it also be possible to integrate this into a potential 4.3.x release? |
pieterlexis
approved these changes
Oct 22, 2020
pdns/packethandler.cc
Outdated
|
|
||
| if (publishCDNSKEY == "0") { // delete DS via CDNSKEY | ||
| rr.dr.d_content=std::make_shared<DNSKEYRecordContent>("0 3 0 AA=="); |
There was a problem hiding this comment.
"0 3 0 AA==" and "0 0 0 00" are candidates to become two const static string
There was a problem hiding this comment.
with https://www.rfc-editor.org/errata/eid5049 in a comment near them
From API perspective (PUBLISH-)CDNSKEY/(PUBLISH-)CDS is not special, it is just metadata. Metadata modification is already covered by the current API tests. |
mind04
force-pushed
the
pdns-cds-cdnskey
branch
from
2482b0f
to
3c9fde0
Compare
mind04
force-pushed
the
pdns-cds-cdnskey
branch
from
3c9fde0
to
481508a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
PUBLISH-CDNSKEY = 0 and PUBLISH-CDS = 0 now create a dnssec delete cds/cdnskey
"pdnsutil set-publish-cdnskey ZONE delete" and "pdnsutil set-publish-cds ZONE 0" can be used to create these metadata items.
Closes: #8545
Checklist
I have: