Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum for ctype indication in the C-API #306

Merged
merged 9 commits into from Jul 13, 2023
Merged

Use enum for ctype indication in the C-API #306

merged 9 commits into from Jul 13, 2023

Conversation

TonyXiang8787
Copy link
Member

Problem

Previously we use string to indicate the ctype of an attribute in the C-API. This results in slow string look-up.

Solution

We change it to enum.

@TonyXiang8787
add ctype enum
6d33aad 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix all tests
e8e9985 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
modify python side
9b8cd3c 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix mypy
f94727f 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
clang format
d9de483 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
require without brace
dd5c5dc 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
enum in python side
e600bc0 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix mypy
217e767 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix pylint
15ba37d 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
mgovers
mgovers previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, overall a really nice improvement

power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_data.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_data.hpp Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_data.hpp Outdated Show resolved Hide resolved
src/power_grid_model/core/power_grid_meta.py Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model_c/include/power_grid_model_c/meta_data.h Show resolved Hide resolved
mgovers
mgovers previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with all comments

mgovers
mgovers previously approved these changes Jul 13, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TonyXiang8787 TonyXiang8787 merged commit 97a2e1e into release/short-circuit-calculation Jul 13, 2023
28 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/enum-ctypes branch July 13, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TonyXiang8787 @mgovers