Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor indptr / sparse structure #379

Merged
merged 73 commits into from Oct 12, 2023
Merged

Refactor indptr / sparse structure #379

merged 73 commits into from Oct 12, 2023

Conversation

nitbharambe
Copy link
Member

No description provided.

nitbharambe and others added 2 commits September 12, 2023 11:37
@nitbharambe
add rough structure
b54a0d0 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Update test_sparse_idx_vector.cpp
5c3e20d 
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
mgovers
mgovers reviewed Sep 12, 2023
View reviewed changes
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_sparse_idx_vector.cpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
nitbharambe and others added 5 commits September 12, 2023 14:36
@nitbharambe
address initial comments
af1e20a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Update sparse_idx_vector.hpp
950e607 
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe
fix smell
cf3cf58 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add data size function
c5e92c0 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
combine structures
e08ff3b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe and others added 13 commits September 13, 2023 13:16
@nitbharambe
minor fix
fc1f0e5 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
make only map
d9ebeca 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix spell
18052a4 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix structure
22455c1 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
modify example
2c2d455 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
redesign structure
09c2b46 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add items
658ebb9 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix sonar
a056ba7 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add groups
91141d5 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add groups items
e927645 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
clean up types
17020d7 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add comment
270b960 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into feature/refactor-indptr
e8bd332
@nitbharambe nitbharambe marked this pull request as ready for review September 22, 2023 12:24
mgovers
mgovers reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good

power_grid_model_c/power_grid_model/include/power_grid_model/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_idx_vector.hpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_sparse_idx_vector.cpp Outdated Show resolved Hide resolved
@nitbharambe
with groups temp
1dab96d 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove unrequired code
0e7b238 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'feature/refactor-indptr' of https://github.com/PowerGri…
aa924ee 
…dModel/power-grid-model into feature/refactor-indptr
@mgovers
fix
5df2e6b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
sonar cloud
0a99e31 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
no constexpr vector constructors
e76e740 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix inline
b669ae2 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix move
020df69 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review October 11, 2023 12:44
@mgovers mgovers mentioned this pull request Oct 11, 2023
Merged
@mgovers
gcc apparently has incomplete constexpr library support
e0c3242 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
make both sonar cloud and macos happy
cf2f8c6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
mgovers previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is about as far as we can go for this PR. i have not run into any new issues on my refactor branch so so far, so good

@mgovers
make grouped idx vector iterator regular
ec11c95 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix
53e206e 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
enumerated zip sequence
b5fa5aa 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Member

mgovers commented Oct 12, 2023

@TonyXiang8787 this is ready for review

@TonyXiang8787
Copy link
Member

@mgovers please fix build error

@mgovers
cast ptrdiff to fix macos again
38dcf69 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TonyXiang8787 TonyXiang8787 merged commit 947e716 into main Oct 12, 2023
28 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/refactor-indptr branch October 12, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitbharambe @mgovers @TonyXiang8787