Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor solvers #390

Merged
merged 55 commits into from Oct 10, 2023
Merged

Refactor solvers #390

merged 55 commits into from Oct 10, 2023

Conversation

petersalemink95
Copy link
Member

@petersalemink95 petersalemink95 commented Sep 25, 2023 •
edited

Refactor solvers for better readability: split large solver functions into smaller functions.

  • linear PF solver
  • (iterative PF solver)
  • iterative current PF solver
  • newton raphson PF solver
  • short circuit solver

@petersalemink95
linear pf solver -> add loads and sources
322a77c 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
linear pf solver -> copy y bus
f3614c4 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
remove lines
58c9dad 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
sc solver -> copy y bus
cb0e14b 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
remove *c
2934f5c 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
linear pf -> general functions
d8e40ee 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
sc solver -> prep matrix + rhs func
7acc5b2 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
sc solver -> add sources
1a23260 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
sc solver -> add faults
2516039 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
sc solver -> add fault with inf imp
1875553 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
sc solver -> add 3p fault with inf imp
0b8162d 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
sc solver 1p to ground
359a208 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
add two ph faults
8ce4655 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
reformat requires
89de420 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
add_fault
6401561 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
add all faults
adfaa80 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
remove empty SC test file
a74c2dd 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
NR -> replace i with bus_number
0936183 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
linear PF -> calculate source result
c49652b 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
linear PF -> calculate load_gen result
990cca1 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
rename k to diagonal position
766c9a4 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
NR -> add_loads
2dc9228 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
NR -> separate add load
811de96 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
NR add sources
657a2ab 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
move func
d761910 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
prep matrix from network perspective
cfecb6b 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
rename i with row
9d337f7 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
it pf solver calc source
8a7c368 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
it pf solver calc load gen
869fa7e 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
use abs2
dfa9efc 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
petersalemink95 and others added 15 commits September 27, 2023 11:43
@petersalemink95
when requires not sym use false 2
0adf80c 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
add extra if constexpr(sym)
5f4b367 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
not sym
5b9190d 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
similar add_sources, linear PF, SC
a367122 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
move add_sources out of sc solver and linear pf solver
b85f8f9 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
add shared solver functions.hpp
81d79ca 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
copy y_bus for sc solver
cbfe628 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
add copy y bus lin PF / it curr PF
5dac9ac 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
remove unused variable
6e65ccf 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
calculate source
b67ab7d 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
calc load gen result
ca997c6 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
use lambda
5d172c3 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
/*i*/
f39065d 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
make add fault functions larger again
d2b212d 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Merge branch 'main' into feature/split-physics-and-math
b2f4e45
@petersalemink95 petersalemink95 marked this pull request as ready for review October 6, 2023 08:20
@petersalemink95
code smells p1
62ee982 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Merge branch 'feature/split-physics-and-math' of https://github.com/P…
939fc2b 
…owerGridModel/power-grid-model into feature/split-physics-and-math

g Please enter a commit message to explain why this merge is necessary,
merge main
mgovers
mgovers reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice cleanup. it looks a lot more readable to me (obviously, you may think differently but that's my opinion)

power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/linear_pf_solver.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/linear_pf_solver.hpp Outdated Show resolved Hide resolved
...id_model_c/power_grid_model/include/power_grid_model/math_solver/shared_solver_functions.hpp Outdated Show resolved Hide resolved
...id_model_c/power_grid_model/include/power_grid_model/math_solver/shared_solver_functions.hpp Outdated Show resolved Hide resolved
...id_model_c/power_grid_model/include/power_grid_model/math_solver/shared_solver_functions.hpp Outdated Show resolved Hide resolved
petersalemink95 and others added 3 commits October 9, 2023 15:58
@petersalemink95 @mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/m…
43c2bce 
…ath_solver/shared_solver_functions.hpp

Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Peter Salemink <66305765+petersalemink95@users.noreply.github.com>
@petersalemink95
const -> static
717b7b7 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
rename to common solver functions
62ab3b9 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
petersalemink95 and others added 2 commits October 9, 2023 16:24
@petersalemink95
add all
d8beafa 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Merge branch 'main' into feature/split-physics-and-math
8a8e580
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

98.5% 98.5% Coverage
2.8% 2.8% Duplication

@mgovers mgovers merged commit c402a71 into main Oct 10, 2023
28 checks passed
@mgovers mgovers deleted the feature/split-physics-and-math branch October 10, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petersalemink95 @mgovers