Feature/full clang tidy after indptrs

[mgovers]

• Fix clang-cl warning
• Force clang-tidy on Windows to use clang-cl as basic compiler back-end
• Full build with clang-tidy on local device
• Fix any new issues for clang-tidy-16 not captured by clang-tidy-15 (only locally verified; not run in CI)
• Full run clang-tidy workflow in CI (in https://github.com/PowerGridModel/power-grid-model/actions/runs/6546516397 )
  • Repro + report bug in msgpack moved to [BUG] Msgpack may clean up data twice #404

[petersalemink95]

Looks good to me, had some small questions (mainly for my own understanding)

[TonyXiang8787]

@mgovers is this something we need for now? clang-tidy already checks all the core part (everything used by the C-API) right?

[mgovers]

@mgovers is this something we need for now? clang-tidy already checks all the core part (everything used by the C-API) right?

i found some performance issues while implementing the other PR that were not caught by the CI version of clang-tidy (on model.cpp). I don't know why, but doing a full clang-tidy run on all files actually did find the issue

Maybe we can run clang-tidy on all files on main in a nightly run only?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication