Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zip sparse grouped idx vector #407

Merged
merged 17 commits into from Oct 19, 2023

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Oct 18, 2023

No description provided.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the improvement Improvement on internal implementation label Oct 18, 2023
@mgovers mgovers self-assigned this Oct 18, 2023
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@TonyXiang8787
Copy link
Member

@mgovers can you have a look at the sonar failure?

@mgovers
Copy link
Member Author

mgovers commented Oct 18, 2023

@mgovers can you have a look at the sonar failure?

yes. will do after i fix the highest priority blocker on the CIM conversions

mgovers and others added 4 commits October 18, 2023 15:41
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mgovers
Copy link
Member Author

mgovers commented Oct 19, 2023

remaining code smells are introduced by older PRs and I consider them out of scope of this PR.

@TonyXiang8787 TonyXiang8787 merged commit 6ebca96 into main Oct 19, 2023
28 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/zip-sparse-grouped-idx-vector branch October 19, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants