Feature addition to check if p_sigma and q_sigma co-(in)exist.
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Nov 14, 2023
…revent KeyError Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Nov 17, 2023
|
How on the actual earth can I get rid of the |
…ified logic checking `p_sigma` and `q_sigma`. Also bumped reuse version. Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Nov 20, 2023
mgovers
reviewed
Nov 20, 2023
…air. Included parameterized test cases that enumerates all possible combinations. Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…ttps://github.com/Jerry-Jinfeng-Guo/power-grid-model into feature/DGC-2051-data-validation-routine-in-python
updated the doc: fixed the markdown link Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Nov 22, 2023
…ensor`; added test cases for data containing both components, `sym_power_sensor` and `asym_power_sensor`. Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Nov 22, 2023
…); fixed `any()`; error ids more explicitly verified; Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Nov 24, 2023
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
# name and number of the issueDraft PR