Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update topology to not necessarily go through sparse mapping #426

Merged
merged 37 commits into from Dec 22, 2023
Merged

update topology to not necessarily go through sparse mapping #426

merged 37 commits into from Dec 22, 2023

Conversation

Laurynas-Jagutis
Copy link
Member

Fixes issue: update topology to not necessarily go through sparse mapping

@Laurynas-Jagutis
add comments, add test, add wip on build_dense_mapping
a984196 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis Laurynas-Jagutis added the feature New feature or request label Nov 13, 2023
@Laurynas-Jagutis
Copy link
Member Author

Current task: update the sorting, so that the complexity of the algorithm would be linear

@Laurynas-Jagutis
work in progress
a66b989 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
fix dense mapping indvector and reorder
7ebe6f3 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
Merge remote-tracking branch 'origin/main' into feature/update-topology
1830797
@Laurynas-Jagutis
fix narrowing conversion
a63d8ec 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
remove assertion
404c3a5 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
comment out an assert
ac073bb 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
mgovers and others added 8 commits November 24, 2023 11:58
@mgovers
Merge branch 'main' into feature/update-topology
7a3e00b
@Laurynas-Jagutis
update test, combine two loops
e77692c 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
Merge branch 'feature/update-topology' of https://github.com/PowerGri…
3b0ae2e 
…dModel/power-grid-model into feature/update-topology
@Laurynas-Jagutis
Merge remote-tracking branch 'origin/main' into feature/update-topology
dee666b
@Laurynas-Jagutis
wip
6dccb02 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
finished the new sorting, works well
c924777 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
setup if statement, count operations
0984153 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
Merge remote-tracking branch 'origin/main' into feature/update-topology
2f89787
@Laurynas-Jagutis
benchmarks
084e463 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
Merge remote-tracking branch 'origin/main' into feature/update-topology
0d6dcf8
@Laurynas-Jagutis
almost finished full script
a6404da 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
finish script, obtain results
771a20f 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
reverse the idxvector
601a344 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
Merge remote-tracking branch 'origin/main' into feature/update-topology
43a1531
@Laurynas-Jagutis
hardcode, remove benchmark, remove comments
2c85fce 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
cast a value to Idx
9dce76c 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Laurynas-Jagutis and others added 5 commits December 15, 2023 12:05
@Laurynas-Jagutis
possible fixes for failing checks
17e878d 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
possible fixes for failing checks2
70c876b 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
create a test for comparison sort
3f39f43 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis
create a second test
c3daedd 
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@mgovers
Merge branch 'main' into feature/update-topology
225a6a9
mgovers
mgovers reviewed Dec 18, 2023
View reviewed changes
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_mapping.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_mapping.hpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_sparse_mapping.cpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_mapping.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/sparse_mapping.hpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_sparse_mapping.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_sparse_mapping.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_sparse_mapping.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_sparse_mapping.cpp Outdated Show resolved Hide resolved
mgovers and others added 8 commits December 19, 2023 10:58
@mgovers
resolve comments
ab30c76 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
resolve remaining comments
194195a 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
implement do not go via sparse when dense mapping
aa36ef0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
cleanup
ed83f7f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix
34b3644 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
iota not correctly implemented in libc++/11
9393ab1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix
bbfda49 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/update-topology
1fa03ce
@mgovers mgovers marked this pull request as ready for review December 19, 2023 15:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TonyXiang8787 TonyXiang8787 merged commit 7c6de68 into main Dec 22, 2023
26 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/update-topology branch December 22, 2023 07:45
@mgovers mgovers mentioned this pull request Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Laurynas-Jagutis @mgovers @TonyXiang8787