Feature/dgc 2055 get batch size function #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgovers
reviewed
Nov 17, 2023
…ng use of existing utils function in validation. Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…ing. Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo
force-pushed
the
feature/DGC-2055-get-batch-size-function
branch
from
8aae5c2
to
3d77bdc
Compare
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
requested changes
Nov 20, 2023
…atch size across components; removed `CConstDataset` interface, use `Dict[str, ndarray]` instead for sparse batch data creation; included `batch_data_array` size functionality and test cases; added interface import to the api reference. Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…thub.com/Jerry-Jinfeng-Guo/power-grid-model into feature/DGC-2055-get-batch-size-function
mgovers
reviewed
Nov 23, 2023
mgovers
reviewed
Nov 24, 2023
…nt`; etc Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Nov 24, 2023
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the interface function that returns the size of batch data, or raises error when the data is inconsistent.