Feature/standard layout input #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
commented
Nov 20, 2023
power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/input.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/input.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
@TonyXiang8787 this is ready for review |
mgovers
commented
Nov 21, 2023
There was a problem hiding this comment.
should i also revert parts of https://github.com/PowerGridModel/power-grid-model/pull/276/files#diff-2bac4fa15db710784f8450b130e98864e112b2b5e4b104c0470f876d5894f4eeL138-R141 ? or is that not necessary? or maybe we can use offsetof also in those functions?
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
@TonyXiang8787 did everything as discussed, including conversion to base types. The following is created in #435
|
TonyXiang8787
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365
Implements all input, output and update data structures as standard layout by using flat attribute expansion in the generated code. conversions to former base types is now done using
reinterpret_castRelates to #241 and #276