Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRSE low level design #455

Merged
merged 40 commits into from Dec 22, 2023
Merged

NRSE low level design #455

merged 40 commits into from Dec 22, 2023

Conversation

nitbharambe
Copy link
Member

Fixes issue: # name and number of the issue

Changes proposed in this PR include:

Structure of NRSE solver to be added

mgovers and others added 28 commits November 29, 2023 13:02
@mgovers
Revert "reduce nrse to interface only"
5582b8a 
This reverts commit ed0b2c8.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix header guard
996f8a4 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge remote-tracking branch 'origin/feature/NRSE-interface' into fea…
cebbbae 
…ture/NRSE-general-structure

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge remote-tracking branch 'origin/feature/NRSE-interface' into fea…
7ee09ab 
…ture/NRSE-general-structure

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/NRSE-general-structure
f526496
@nitbharambe
[skip ci] make fills to separate files
a7702c8 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] change adding of values
cfde7da 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] checkpoint split block things
a001bde 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] add most structure
88d6e49 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] equations fix
0b62f65 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
wip correct types
3d64948 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] type fix
54a8bcb 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into feature/NRSE-general-structure
821e0df
@nitbharambe
[skip ci] wip split jacobian
f2f5203 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] weird merge
2f0e94f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] wip branch restructure
4a844b0 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] making types work
466566d 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
[skip ci] clean comment
a60f0cd 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@mgovers
Merge branch 'main' into feature/NRSE-general-structure
52321cc
@nitbharambe
Merge branch 'main' into feature/NRSE-general-structure
8c78ade
@nitbharambe
remove all content
905c221 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove extra line
855c3bb 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove unused variable
20ccead 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove unused variable function
7e17112 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
nest namespace
39581d1 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove space
8d7bdea 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove result
1b3e65b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove diagonal inverse
82d5cf4 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review December 19, 2023 13:31
nitbharambe and others added 4 commits December 19, 2023 14:38
@nitbharambe @mgovers
Apply suggestions from code review
ee09eb6 
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe
add namespace solvers
75821b1 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add namespace solvers fix
67a35ce 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
namespace concat
b223787 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
namespace rename
ed9002c 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
make namespace changes
7e009dc 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
make namespace changes 2
55febd6 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
format sparse_solver
5c22621 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
address namespace comments
eec38e0 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
mgovers reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest of the PR looks good, but i still have a couple remarks (mostly the same one repeated)

...r_grid_model_c/power_grid_model/include/power_grid_model/math_solver/iterative_pf_solver.hpp Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/linear_pf_solver.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/linear_pf_solver.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/math_solver.hpp Show resolved Hide resolved
...d_model_c/power_grid_model/include/power_grid_model/math_solver/newton_raphson_pf_solver.hpp Outdated Show resolved Hide resolved
...d_model_c/power_grid_model/include/power_grid_model/math_solver/newton_raphson_se_solver.hpp Outdated Show resolved Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/math_solver/short_circuit_solver.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/sparse_lu_solver.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/linear_pf_solver.hpp Outdated Show resolved Hide resolved
@nitbharambe
move to math solver namespace
00fe7bb 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Copy link
Member Author

@mgovers I have now moved all inside math_solver namespace except Ybus and MathSolver

mgovers
mgovers reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one very small nitpick

power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp Outdated Show resolved Hide resolved
@mgovers
nitpick
09f954b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

7 New issues
0 Security Hotspots
83.7% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers merged commit 327d5ba into main Dec 22, 2023
26 checks passed
@mgovers mgovers deleted the feature/NRSE-low-level-design-2 branch December 22, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nitbharambe @mgovers