[Hotfix] fix restore after failing batch scenario #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
requested review from
Jerry-Jinfeng-Guo,
TonyXiang8787,
petersalemink95,
nitbharambe and
zhen0427
|
Failing CI is due to boost artifactory bug boostorg/boost#842 |
TonyXiang8787
approved these changes
Jan 9, 2024
yes indeed. In the near future, a sustainable solution will improve on this. Since this is a hotfix, fixing functionality is more important than performance |
re-running after TonyXiang8787/pybuild-header-dependency#3 fixed the boost URL |
|
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #461
Changes proposed in this PR include:
This is a hotfix that does not care about performance.
Approprate sustainable solution will be done in #460 .