Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NRSE line measurement implementation #478

Merged
merged 45 commits into from Feb 6, 2024
Merged

Fix NRSE line measurement implementation #478

merged 45 commits into from Feb 6, 2024

Conversation

nitbharambe
Copy link
Member

Related issue: #369
Fixes implementation of NRSE for line measurements #438

Changes proposed in this PR include:

Fixes implementation of line
Adds a unit test for line
Refactor and reduce complexity and align it towards mathematical workout for line measuremenets

Could you please pay extra attention to the points below when reviewing the PR:

nitbharambe and others added 3 commits January 24, 2024 22:06
@nitbharambe
fix multiplication
8d5e631 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
rearrange branch injection
6a2802f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'feature/NRSE-general-structure' into fix/nrse-line-meas…
44d3f15 
…urements

Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@mgovers mgovers mentioned this pull request Jan 25, 2024
Merged
@nitbharambe
refactor big blocks
c018a17 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix adding to both
1fbec29 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove commentted code
03d5101 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
change condition
4562c35 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
rename to workout
3c62f60 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
rename del to delta
6ad0718 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
pre-merge to comments
2f49229 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add docstring
38c1b0f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe and others added 5 commits January 29, 2024 13:18
@nitbharambe
merge fixes to angle
0d6e780 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@mgovers
add newton raphson state estimation unit tests to math solver
cb21b9f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@nitbharambe
add shunt tests
632412a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'feature/NRSE-general-structure' into fix/nrse-line-meas…
098c961 
…urements

Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe
fix injection variance
cbcba36 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers and others added 10 commits January 30, 2024 14:40
@mgovers
Merge branch 'feature/NRSE-general-structure' into fix/nrse-line-meas…
6aea7f5 
…urements
@mgovers
minor
de343e4 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
format
00d4325 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'feature/NRSE-general-structure' into fix/nrse-line-meas…
c6cec66 
…urements
@nitbharambe
fix branch logic
b54487c 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove rough branch logic
5ddaa96 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
improve readability
12cfb32 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'fix/nrse-line-measurements' of https://github.com/Power…
6d397e1 
…GridModel/power-grid-model into fix/nrse-line-measurements
@nitbharambe
refactor zero voltage angle
e54b85a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix spell
307bf50 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
correct lagrange multiplier
0027661 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix tau
061d592 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove unused variable
1cac73b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix shunt
5e273ac 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
xfail distribution and sensor update
ec04c22 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
refactor, fix any zero to all zero
7b37e15 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
mgovers reviewed Feb 6, 2024
View reviewed changes
tests/cpp_unit_tests/test_main_model_se.cpp Outdated Show resolved Hide resolved
tests/data/state_estimation/1os2msr-no-angle/params.json Outdated Show resolved Hide resolved
tests/data/state_estimation/1os2msr/params.json Outdated Show resolved Hide resolved
tests/data/state_estimation/dummy-test-sym/params.json Outdated Show resolved Hide resolved
tests/data/state_estimation/high-variance-measurement/params.json Outdated Show resolved Hide resolved
tests/data/state_estimation/node-injection-sensor-and-zero-injection/params.json Outdated Show resolved Hide resolved
tests/data/state_estimation/three_winding_transformer/params.json Outdated Show resolved Hide resolved
tests/data/state_estimation/single-line-load/params.json Show resolved Hide resolved
tests/data/state_estimation/transmission-case/params.json Outdated Show resolved Hide resolved
mgovers and others added 10 commits February 6, 2024 09:19
@mgovers
fix NRSE validation jsons
5247ea4 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix compiler warning
b46998b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'feature/NRSE-general-structure' into fix/nrse-line-meas…
1dcccea 
…urements
@mgovers
Merge branch 'fix/nrse-line-measurements' of https://github.com/Power…
84b3e65 
…GridModel/power-grid-model into fix/nrse-line-measurements
@mgovers
minor resolve comments
9940af1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
refactor iteration logic
bada724 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
refactor
451a420 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
replace inline comments by multiline docstrings
be53049 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix bug in measured values
f7e2cf0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix clang tidy
cdcd535 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review February 6, 2024 10:24
mgovers
mgovers approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are OK. Final review in the base branch

@mgovers mgovers merged commit 5eddc40 into feature/NRSE-general-structure Feb 6, 2024
24 checks passed
@mgovers mgovers deleted the fix/nrse-line-measurements branch February 6, 2024 10:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
99.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersalemink95 petersalemink95 petersalemink95 left review comments

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitbharambe @mgovers @petersalemink95