Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notebook example of asymmetric calculations. #482

Merged
merged 8 commits into from Feb 5, 2024
Merged

Add notebook example of asymmetric calculations. #482

merged 8 commits into from Feb 5, 2024

Conversation

zhen0427
Copy link
Contributor

@zhen0427 zhen0427 commented Jan 30, 2024 •
edited by mgovers

Fixes #447

@zhen0427
First draft of asymmetric calculation example.
4795986 
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
mgovers
mgovers reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review the rest later today

docs/examples/Asymmetric Calculation Example.ipynb Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments on formality.

docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
mgovers
mgovers reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good example. a couple nitpicks remaining

docs/index.md Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My train is arriving at Utrecht, I'll submit this review for now and continue on my next train

docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second half

docs/examples/Asymmetric Calculation Example.ipynb Show resolved Hide resolved
docs/examples/Asymmetric Calculation Example.ipynb Outdated Show resolved Hide resolved
@Jerry-Jinfeng-Guo
Copy link
Contributor

It's all looking good now, I have no complains.

mgovers
mgovers reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one nitpick

docs/index.md Outdated Show resolved Hide resolved
TonyXiang8787
TonyXiang8787 previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@TonyXiang8787 TonyXiang8787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I hereby approve the PR and set to auto-merge.

@TonyXiang8787 TonyXiang8787 changed the title First draft of asymmetric calculation example. Add notebook example of asymmetric calculation example. Feb 5, 2024
@TonyXiang8787 TonyXiang8787 changed the title Add notebook example of asymmetric calculation example. Add notebook example of asymmetric calculations. Feb 5, 2024
@mgovers
update docs
f634e16 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the documentation Improvements or additions to documentation label Feb 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TonyXiang8787 TonyXiang8787 merged commit feb0728 into main Feb 5, 2024
27 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/asym_cal_example branch February 5, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 left review comments

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create example notebook for asymmetric calculation
4 participants
@zhen0427 @Jerry-Jinfeng-Guo @mgovers @TonyXiang8787