Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRSE documentation #488

Merged
merged 14 commits into from Feb 13, 2024
Merged

NRSE documentation #488

merged 14 commits into from Feb 13, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Feb 7, 2024

@mgovers mgovers self-assigned this Feb 7, 2024
@mgovers mgovers added the documentation Improvements or additions to documentation label Feb 7, 2024
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review February 9, 2024 12:53
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Mostly suggestions on wording.

docs/user_manual/calculations.md Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
@Jerry-Jinfeng-Guo
Copy link
Contributor

Upon discussion with @TonyXiang8787 , the reviews are incorporated into the documentation and all related conversations are hereby resolved.

Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo merged commit 8590014 into main Feb 13, 2024
27 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/nrse-documentation branch February 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants