Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize NRSE #495

Merged
merged 21 commits into from Feb 15, 2024
Merged

Finalize NRSE #495

merged 21 commits into from Feb 15, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Feb 15, 2024

  • prepare_matrix_and_rhs:
    • BUG: (L250) also clear fill-in
    • (L328) no prefactorize is needed.
  • The NRSEGainBlock (L64-L67):
    • qt should be (hermitian) transposed
    • qt should be directly obtained from hermitian transpose instead of per element
  • Run_state_estimation:
    • (L163) run solve directly using prefactorize_and_solve
  • fix dense grouped index vector not initialized by default
  • sensor-update case for NRSE
  • distribution-case for NRSE and iterative linear
  • single-line-load case

Relates to #369

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the bug Something isn't working label Feb 15, 2024
@mgovers mgovers self-assigned this Feb 15, 2024
mgovers and others added 7 commits February 15, 2024 10:54
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787 TonyXiang8787 changed the title Fix NRSE after math review Finalize NRSE Feb 15, 2024
@TonyXiang8787
Copy link
Member

After examination I have concluded that the case sensor-update has indeed another local minimum for NRSE. Thus a new test case created.

@mgovers
Copy link
Member Author

mgovers commented Feb 15, 2024

After examination I have concluded that the case sensor-update has indeed another local minimum for NRSE. Thus a new test case created.

ok, clear. i'm working on the block matrix thingy. should i do that in this PR or a separate one?

@TonyXiang8787
Copy link
Member

After examination I have concluded that the case sensor-update has indeed another local minimum for NRSE. Thus a new test case created.

ok, clear. i'm working on the block matrix thingy. should i do that in this PR or a separate one?

Just push to here. We try to finish everything.

@mgovers
Copy link
Member Author

mgovers commented Feb 15, 2024

After examination I have concluded that the case sensor-update has indeed another local minimum for NRSE. Thus a new test case created.

ok, clear. i'm working on the block matrix thingy. should i do that in this PR or a separate one?

Just push to here. We try to finish everything.

i would like to do the version bump + remove experimental flag in a separate PR, just to really make sure that that version bump is extremely minimal and that we don't end up finding something again before pushing

mgovers and others added 12 commits February 15, 2024 15:02
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787 TonyXiang8787 marked this pull request as ready for review February 15, 2024 15:03
TonyXiang8787
TonyXiang8787 previously approved these changes Feb 15, 2024
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@mgovers
Copy link
Member Author

mgovers commented Feb 15, 2024

I see no more weird/unexpected things. CI appears to go OK both locally and remotely. Hereby enabling automerge

Copy link

sonarcloud bot commented Feb 15, 2024

@mgovers mgovers merged commit 9bb0ed4 into main Feb 15, 2024
27 checks passed
@mgovers mgovers deleted the bugfix/nrse-maths-review branch February 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants