-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF outputs on diagrams #47
base: master
Are you sure you want to change the base?
Conversation
Thank you for this contribution too. But also again ;), a few remarks/comments for discussions:
@casella any opinion on this? |
I now realise that the solution I enclosed in the PR, although optimal for what I was doing when I conceived it, is not the best one for the general public, and I should probably withdraw it. I first add some comments on your points: 1: global/local: good point, in case the idea is accepted it would be good to have both; having just local is a minimal starting point 2: this is one most important point. Now I think it would be better to have powers in MW and voltages in kV. In fact, the values now shown are those given by PowerGrids, and therefore are each in pu of their respective component base. In a general diagram, they should preferably be in one base. Since PowerGrids is not designed to consider a unique pu base for the whole system, this one reference for PF numbers must necessarily be the S.I. 3: I chose 3 digits because I think IS the best compromise between precision and space occupation. If one needs larger precision, they can directly look at the numerical values, as they do now. A variable number of digits could easily overcome parts of diagrams. However, obviously making this precision customizable is a plus that doesn't harm. I propose 3 as the default number of digits There are other reasons for which my intention is to close this PR and possibly open a different one, with enhancements: a) the sign of powers. How the signs are "well done" since they follow the general convention of MSL: positive when entering the component to which a terminal belongs. But later I've seen the way OpenIpsl does: the numbers are always positive, but below them small arrows with the actual directions are shown. This is more immediate to understand and occupy a reasonably small space: @casella, @adriguir, what do you think? b) voltages. I know that we can connect components to each other without interposing buses; however, the use of buses is somewhat the PowerGrids standard. Starting from this, we could add voltages to buses and drop them from terminals of lines and transformers. Again, this is the solution adopted by OpenIpsl, and I like it. BTW this allows the voltage angles to be displayed as well. My bottom line is that for PF it is really mandatory to have a graphical display of numbers. Otherwise looking at the from the numerical output is a nightmare: typically I printed the diagram and put by hand the numbers on paper... just before realising that I wanted a different case to be simulated, and therefore had to start everything again!. As the solution for PowerGrids, I propose to:
|
This PR allows terminal active and reactive power and voltage (all p.u.) to be shown on diagrams.
This is especially useful for PowerFlow analysis since allows to have on the diagram the full picture of what it's happening. Retrieving manually all these data would require much more time.
This feature has been added to
In case this PR is accepted, maybe I could extend it to other components, with a new PR.
This feature is kept disabled by default.
It was enabled just on the examples:
This PR has been checked successfully with Dymola. WIth OpenModelica it does not work yet, but the support of the DynamicSelect technology, used in this PR, is being added to OM as well.