Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specific Comparator Layout will crash a server #1174

Closed
FlamingKnight opened this issue Jul 2, 2021 · 5 comments · Fixed by #1204
Closed

Specific Comparator Layout will crash a server #1174

FlamingKnight opened this issue Jul 2, 2021 · 5 comments · Fixed by #1204
Assignees
@joserobjr @FlamingKnight
Labels
Implementation: Block This issue or pull request is about the implementation of a block Implementation: BlockEntity This issue or pull request is about the implementation of a blockentity priority:0 Showstopper. Critical for the next release Tag: Redstone Issues related to redstone Type: bug Something isn't working
Milestone
1.5.2.0-PN

Comments

@FlamingKnight
Copy link

🐞 I found a bug

Placing down a comparator in the system below, will crash the server giving a StackOverflowError

📸 Screenshots / Videos

▶ Steps to Reproduce

Place down the layout below, and restart the server, rejoin, observe

❌ Actual Behavior

Minecraft 7_2_2021 3_04_13 PM

Server will crash for everyone

📋 Debug information

  • PowerNukkit version: 1.5.0.0-PN

💢 Crash Dump, Stack Trace and Other Files

https://pastebin.com/nvYGtTWW

💬 Anything else we should know?

Nope

Minecraft.2021-07-02.15-03-05.mp4
@FlamingKnight FlamingKnight added the Type: bug Something isn't working label Jul 2, 2021
@powernukkit
Copy link

powernukkit bot commented Jul 2, 2021

Hey @FlamingKnight, thank you for the report!

📦 Detected the version: 1.5.0.0-PN

@FlamingKnight FlamingKnight mentioned this issue Jul 5, 2021
Closed
@whes1015
Copy link

whes1015 commented Jul 6, 2021

I have the same problem

@FlamingKnight
Copy link
Author

I fixed it in PR #1179 , waiting on a review and merge

This was linked to pull requests Jul 14, 2021
Comparator fix #1179
Closed
Fix Double Chests #1190
Closed
@joserobjr
Copy link
Member

nvYGtTWW.txt

@joserobjr joserobjr mentioned this issue Jul 14, 2021
Closed
@joserobjr joserobjr self-assigned this Jul 14, 2021
joserobjr added a commit that referenced this issue Jul 15, 2021
@joserobjr
Fixes #1174 Infinite loop with double chest and comparator
0f7ba12
@joserobjr joserobjr added this to the 1.5.2.0-PN milestone Jul 15, 2021
@joserobjr joserobjr mentioned this issue Jul 15, 2021
Merged
@joserobjr joserobjr linked a pull request Jul 15, 2021 that will close this issue
Fixes #1174 Infinite loop with double chest and comparator #1204
Merged
@roridev roridev mentioned this issue Oct 24, 2021
Closed
@roridev roridev added Implementation: Block This issue or pull request is about the implementation of a block Implementation: BlockEntity This issue or pull request is about the implementation of a blockentity priority:0 Showstopper. Critical for the next release Tag: Redstone Issues related to redstone labels Oct 24, 2021
LoboMetalurgico added a commit that referenced this issue Oct 26, 2021
@LoboMetalurgico
Merge pull request #1204 from PowerNukkit/fix/double-chest-comparator…
223bd5d 
…-loop

Fixes #1174 Infinite loop with double chest and comparator
@LoboMetalurgico
Copy link
Member

Fixed in #1204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joserobjr joserobjr

@FlamingKnight FlamingKnight

Labels
Implementation: Block This issue or pull request is about the implementation of a block Implementation: BlockEntity This issue or pull request is about the implementation of a blockentity priority:0 Showstopper. Critical for the next release Tag: Redstone Issues related to redstone Type: bug Something isn't working
Projects
None yet
Milestone
1.5.2.0-PN
5 participants
@joserobjr @roridev @LoboMetalurgico @whes1015 @FlamingKnight