Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2] Enchantment cost must not be managed by the client #232

Closed
joserobjr opened this issue May 7, 2020 · 0 comments
Closed

[1.2] Enchantment cost must not be managed by the client #232

joserobjr opened this issue May 7, 2020 · 0 comments
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: enhancement Enhancements and fixes to already existing features
Projects
Triage 1.X
Milestone
1.3.1.0-PN

Comments

@joserobjr
Copy link
Member

Expected Behavior

The server must calculate, deduce and update the player GUI

Actual Behavior

The player calculates the cost, sends to the server and it just obey without validation (with exception for negative cost)

This allows cheaters to enchant anything without paying the level cost or paying a wrong amount

Debug information

1.2.0.0-PN
Related to NukkitX#1372

Crashdump, Backtrace or Other Files
@joserobjr joserobjr added the Type: enhancement Enhancements and fixes to already existing features label May 7, 2020
@joserobjr joserobjr added this to the Future 1.X milestone May 7, 2020
@joserobjr joserobjr added this to Needs triage in Triage 1.X Jun 8, 2020
@joserobjr joserobjr moved this from Needs triage to High priority in Triage 1.X Jun 8, 2020
@joserobjr joserobjr mentioned this issue Jul 2, 2020
Merged
@joserobjr joserobjr modified the milestones: Future 1.X, 1.3.1.0-PN Jul 10, 2020
@joserobjr joserobjr added the Resolution: resolved The issue has been addressed or the request has been accepted label Jul 10, 2020
Triage 1.X automation moved this from High priority to Closed Jul 10, 2020
@joserobjr joserobjr mentioned this issue Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: enhancement Enhancements and fixes to already existing features
Projects
No open projects
Triage 1.X
  
Closed
Milestone
1.3.1.0-PN
Development

No branches or pull requests
1 participant
@joserobjr