Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull commits from NukkitX #326

Merged
merged 11 commits into from
Jul 2, 2020
Merged

Pull commits from NukkitX #326

merged 11 commits into from
Jul 2, 2020

Conversation

joserobjr
Copy link
Member

@joserobjr joserobjr commented Jul 2, 2020

This PR re-enables the enchanting table. It should also fix the #232 issue.

Extollite and others added 7 commits July 1, 2020 13:30
Bumps `log4j2.version` from 2.11.1 to 2.13.3.

Updates `log4j-api` from 2.11.1 to 2.13.3

Updates `log4j-core` from 2.11.1 to 2.13.3

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update EnchantData naming

* Add EnchantItemEvent

* Bump API version

* Implement Enchanting Transaction

* No longer need to remove levels with EventPacket, as it is done by the cost of the transaction
Co-authored-by: Erik Miller <erikmiller04@gmail.com>
# Conflicts:
#	src/main/java/cn/nukkit/Nukkit.java
#	src/main/java/cn/nukkit/Player.java
#	src/main/java/cn/nukkit/network/protocol/AddEntityPacket.java
@joserobjr joserobjr added the Type: bug Something isn't working label Jul 2, 2020
@joserobjr joserobjr added this to the 1.3.1.0-PN milestone Jul 2, 2020
@joserobjr joserobjr self-assigned this Jul 2, 2020
# Conflicts:
#	src/main/java/cn/nukkit/entity/mob/EntityPiglin.java
#	src/main/java/cn/nukkit/entity/mob/EntityZoglin.java
#	src/main/java/cn/nukkit/entity/passive/EntityStrider.java
@joserobjr joserobjr added the Type: enhancement Enhancements and fixes to already existing features label Jul 2, 2020
@joserobjr joserobjr merged commit 597cd7b into bleeding Jul 2, 2020
@joserobjr joserobjr deleted the PN-124 branch July 2, 2020 04:53
@joserobjr joserobjr mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working Type: enhancement Enhancements and fixes to already existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants