Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves findLog allows floating trees #254

Closed
joserobjr opened this issue May 14, 2020 · 0 comments
Closed

Leaves findLog allows floating trees #254

joserobjr opened this issue May 14, 2020 · 0 comments
Assignees
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Milestone

Comments

@joserobjr
Copy link
Member

joserobjr commented May 14, 2020

🐞 I found a bug

The leaves don't check the log is actually to the it, so once all their update_bits are changed the leaves will remain floating until one of the connected leaves receive a block update.

📸 Screenshots / Videos

image

▶ Steps to Reproduce

  1. Run /gamerule randomTickSpeed 400 (the original is 3)
  2. Grow a tree (the leaves needs to be natural)
  3. Break all logs except one
  4. Make sure you have leaves which are disconnected but near the log
  5. Await a few minutes (or seconds if you increase the randomTick gamerule as in step 1)
  6. Notice that none of the disconnected leaves are still there
  7. Break the last log block
  8. Notice that the leaves won't decay
  9. Break a single leaves block
  10. Notice that all leaves that were connected to the broken leaves block will start decaying

✔ Expected Behavior

Start decaying once it has no connected log block in a distance of 7 blocks using manhattan distance

❌ Actual Behavior

The decay process don't check connectivity (1.2.0.1-PN) and caches the connected state incorrectly due to the lack of connectivity check (1.2.0.2-PN-SNAPSHOT)

📋 Debug information

@joserobjr joserobjr added the Type: bug Something isn't working label May 14, 2020
@joserobjr joserobjr added this to the 1.2.0.2-PN milestone May 14, 2020
@joserobjr joserobjr self-assigned this May 14, 2020
joserobjr added a commit that referenced this issue May 16, 2020
@joserobjr joserobjr added the Resolution: resolved The issue has been addressed or the request has been accepted label May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant