Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Level Up sound is not centered #95

Closed
joserobjr opened this issue Jan 19, 2020 · 1 comment
Closed

Level Up sound is not centered #95

joserobjr opened this issue Jan 19, 2020 · 1 comment
Assignees
@joserobjr
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: enhancement Enhancements and fixes to already existing features
Milestone
1.2.0.2-PN

Comments

@joserobjr
Copy link
Member

The sound position gets floored because it's using the PlaySoundPacket instead of LevelSoundEventPacketV2
@joserobjr joserobjr added the Type: enhancement Enhancements and fixes to already existing features label Jan 25, 2020
@joserobjr
Copy link
Member Author

joserobjr commented May 17, 2020 •
edited

Vanilla:

LevelSoundEvent2Packet(
sound=LEVELUP, 
position=(12.028572, 53.9, 0.052643627), 
extraData=1073741824, 
identifier=, babySound=false, relativeVolumeDisabled=false
)

PowerNukkit:

PlaySoundPacket(
sound=random.levelup,
position=(71.0, 78.0, 216.0), 
volume=1.0, pitch=1.0
)

@joserobjr joserobjr self-assigned this May 17, 2020
joserobjr added a commit that referenced this issue May 17, 2020
@joserobjr
PN-67 Adds #95 to the changelog
f168d26
@joserobjr joserobjr mentioned this issue May 17, 2020
Merged
@joserobjr joserobjr added the Resolution: resolved The issue has been addressed or the request has been accepted label May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joserobjr joserobjr

Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: enhancement Enhancements and fixes to already existing features
Projects
None yet
Milestone
1.2.0.2-PN
Development

No branches or pull requests
1 participant
@joserobjr