Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve resource pack related packets #1172

Merged
merged 23 commits into from
Oct 26, 2021
Merged

Fix and improve resource pack related packets #1172

merged 23 commits into from
Oct 26, 2021

Conversation

GoodLucky777
Copy link

@GoodLucky777 GoodLucky777 commented Jul 1, 2021 •
edited

Fix and improve resource pack related packets

  • Set max chunk size as BDS
  • Make able to get and set max chunk size with plugin
  • Fix chunk count calculation
  • Update resource pack related packets (missing version)
  • Speeds up pack download and login process

@LoboMetalurgico LoboMetalurgico added size/M Medium Pull Request Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged Type: bug Something isn't working Type: enhancement Enhancements and fixes to already existing features labels Jul 2, 2021
@LoboMetalurgico LoboMetalurgico requested a review from a team July 2, 2021 22:06
@LoboMetalurgico LoboMetalurgico added this to the 1.5.2.0-PN milestone Jul 2, 2021
@roridev roridev added Merge Type : Squash This pull request shall use "squash" instead of normal merging Tag : RakNet This issue or pull request is about networking labels Jul 7, 2021
@roridev roridev added the priority:0 Showstopper. Critical for the next release label Oct 24, 2021
LoboMetalurgico
LoboMetalurgico requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@LoboMetalurgico LoboMetalurgico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thank you for your Pull Request.

Before approving, I would like you to do a small change.

src/main/java/cn/nukkit/network/protocol/ResourcePackChunkRequestPacket.java Show resolved Hide resolved
src/main/java/cn/nukkit/network/protocol/ResourcePackDataInfoPacket.java Show resolved Hide resolved
@LoboMetalurgico LoboMetalurgico added Status: Awaiting Response The issue or pull request is on hold because it needs more information and removed Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged labels Oct 26, 2021
LoboMetalurgico
LoboMetalurgico approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@LoboMetalurgico LoboMetalurgico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You

@LoboMetalurgico LoboMetalurgico merged commit 450bffa into PowerNukkit:bleeding Oct 26, 2021
@LoboMetalurgico LoboMetalurgico added Resolution: resolved The issue has been addressed or the request has been accepted and removed Status: Awaiting Response The issue or pull request is on hold because it needs more information labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoboMetalurgico LoboMetalurgico LoboMetalurgico approved these changes

Assignees

@GoodLucky777 GoodLucky777

Labels
Merge Type : Squash This pull request shall use "squash" instead of normal merging priority:0 Showstopper. Critical for the next release Resolution: resolved The issue has been addressed or the request has been accepted size/M Medium Pull Request Tag : RakNet This issue or pull request is about networking Type: bug Something isn't working Type: enhancement Enhancements and fixes to already existing features
Projects
None yet
Milestone
1.6.0.1-PN
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GoodLucky777 @LoboMetalurgico @roridev