Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the names for BlockConcrete and BlockConcretePowder #1214

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Fixed the names for BlockConcrete and BlockConcretePowder #1214

merged 2 commits into from
Jul 28, 2021

Conversation

FlamingKnight
Copy link

@FlamingKnight FlamingKnight commented Jul 19, 2021 •
edited

The names for Concrete and Concrete Powder when getting a block, is just concrete, it doesn't specify the colored name of the blocks, this is just a simple fix for it!

@LoboMetalurgico LoboMetalurgico requested a review from a team July 26, 2021 04:52
@LoboMetalurgico LoboMetalurgico added size/S Small Pull Request Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged Type: bug Something isn't working labels Jul 26, 2021
@LoboMetalurgico LoboMetalurgico added this to Not Triaged in Triage via automation Jul 26, 2021
@LoboMetalurgico LoboMetalurgico added this to the 1.5.2.0-PN milestone Jul 26, 2021
LoboMetalurgico
LoboMetalurgico requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@LoboMetalurgico LoboMetalurgico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your Pull Request. I just need you to make a small change to make it conform to the Block Properties system.

src/main/java/cn/nukkit/block/BlockConcretePowder.java Outdated Show resolved Hide resolved
Triage automation moved this from Not Triaged to Awaiting Review Jul 26, 2021
@LoboMetalurgico LoboMetalurgico added Status: Awaiting Response The issue or pull request is on hold because it needs more information and removed Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged labels Jul 26, 2021
LoboMetalurgico
LoboMetalurgico approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@LoboMetalurgico LoboMetalurgico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!

@LoboMetalurgico LoboMetalurgico merged commit cb4ac65 into PowerNukkit:bleeding Jul 28, 2021
Triage automation moved this from Awaiting Review to Merged Jul 28, 2021
@LoboMetalurgico LoboMetalurgico added Resolution: resolved The issue has been addressed or the request has been accepted and removed Status: Awaiting Response The issue or pull request is on hold because it needs more information labels Jul 28, 2021
@FlamingKnight FlamingKnight deleted the pn-concrete-name-fix branch July 28, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoboMetalurgico LoboMetalurgico LoboMetalurgico approved these changes

Assignees

@FlamingKnight FlamingKnight

Labels
Resolution: resolved The issue has been addressed or the request has been accepted size/S Small Pull Request Type: bug Something isn't working
Projects
Triage
Merged
Milestone
1.5.2.0-PN
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FlamingKnight @LoboMetalurgico