Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Disconnect messages not reaching the player sometimes #263

Merged
merged 2 commits into from May 17, 2020
Merged

Fixes Disconnect messages not reaching the player sometimes #263

merged 2 commits into from May 17, 2020

Conversation

joserobjr
Copy link
Member

Fixes #238

Messages now appears correctly:

  • When the player's protocol version is not compatible with the server
  • The player is kicked on login by a plugin cancelling the PlayerLoginEvent
  • The Player.close() is called with any overload combination
  • The server is closed
  • A DisconnectPacket is sent to the player using the Player.directDataPacket(DataPacket) method

@joserobjr joserobjr added the Type: bug Something isn't working label May 17, 2020
@joserobjr joserobjr added this to the 1.2.0.2-PN milestone May 17, 2020
@joserobjr joserobjr self-assigned this May 17, 2020
@joserobjr joserobjr merged commit f4b6a84 into snapshot/v1.2.0.x May 17, 2020
@joserobjr joserobjr added the Resolution: resolved The issue has been addressed or the request has been accepted label May 17, 2020
@joserobjr joserobjr deleted the PN-103 branch July 23, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joserobjr joserobjr

Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Projects
None yet
Milestone
1.2.0.2-PN
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joserobjr