Fix ClassCastException while loading old chunks and some logic errors #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joserobjr
commented
Jul 4, 2020
joserobjr
commented
- Fixes ClassCastException: cn.nukkit.block.BlockUnknown cannot be cast to cn.nukkit.block.BlockWall #328 ClassCastException when the loading chunk has invalid wall states
- Bumps the content version to 2 to trigger a new wall update
- Enhance chunk loading performance (empty chunks will not be checked anymore)
- Update the content version number right after the update, so plugins will get the correct value
joserobjr
added
Type: bug
joserobjr
added
Resolution: resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.