Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes Dried Kelp Block can be used as fuel in furnaces #338

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Makes Dried Kelp Block can be used as fuel in furnaces #338

merged 3 commits into from
Jul 8, 2020

Conversation

Gabriel8579
Copy link
Member

Makes Dried Kelp Block can be used as fuel in furnaces, also add support to ItemBlock to Fuel class

@Gabriel8579
Fixes #161
2e856f1 
Makes Dried Kelp Block can be used as fuel in furnaces, also add support to ItemBlock to Fuel class
@Gabriel8579 Gabriel8579 added Type: bug Something isn't working Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged labels Jul 5, 2020
@Gabriel8579 Gabriel8579 added this to the 1.3.0.1-PN milestone Jul 5, 2020
@Gabriel8579 Gabriel8579 requested a review from a team July 5, 2020 02:39
@Gabriel8579 Gabriel8579 self-assigned this Jul 5, 2020
@Gabriel8579 Gabriel8579 linked an issue Jul 5, 2020 that may be closed by this pull request
Dried Kelp Block is not accepted as fuel #161
Closed
@Gabriel8579 Gabriel8579 modified the milestones: 1.3.0.1-PN, 1.3.1.0-PN Jul 5, 2020
joserobjr
joserobjr requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@joserobjr joserobjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I've found some potential issues, I couldn't test them yet but I left some comments describing them.

src/main/java/cn/nukkit/item/Item.java Outdated Show resolved Hide resolved
@joserobjr joserobjr added Status: Awaiting Response The issue or pull request is on hold because it needs more information and removed Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged labels Jul 8, 2020
@Gabriel8579
Copy link
Member Author

OK, I'm going to fix these issues

@Gabriel8579
Implements methods for adding blocks and items such as fuels
c270e07 
Block addition method checks if the block ID is greater than 255, and subtracts the same from 255, if true
@Gabriel8579 Gabriel8579 added Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged and removed Status: Awaiting Response The issue or pull request is on hold because it needs more information labels Jul 8, 2020
@joserobjr joserobjr changed the base branch from master to bleeding July 8, 2020 14:45
@joserobjr joserobjr modified the milestones: 1.3.1.0-PN, 1.3.0.2-PN Jul 8, 2020
joserobjr
joserobjr approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@joserobjr joserobjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joserobjr joserobjr added Resolution: resolved The issue has been addressed or the request has been accepted and removed Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged labels Jul 8, 2020
@joserobjr joserobjr merged commit 296bf4b into bleeding Jul 8, 2020
@joserobjr joserobjr added this to Closed in Triage 1.X via automation Jul 8, 2020
@joserobjr joserobjr deleted the PN-72 branch July 8, 2020 14:47
@joserobjr joserobjr modified the milestones: 1.3.0.2-PN, 1.3.1.0-PN Jul 10, 2020
@joserobjr joserobjr mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joserobjr joserobjr joserobjr approved these changes

Assignees

@Gabriel8579 Gabriel8579

Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Projects
No open projects
Triage 1.X
  
Closed
Milestone
1.3.1.0-PN
Development

Successfully merging this pull request may close these issues.

Dried Kelp Block is not accepted as fuel
2 participants
@Gabriel8579 @joserobjr