Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes firework being overridden with a black creeper face #438

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

joserobjr
Copy link
Member

Fixes #397

  • Default fireworks does not have a default NBT tag anymore
  • When an entity firework is created without a firework data, it defaults to the old black creeper that was being used by default in the item's NBT tags.
  • Fixed firework spawn position when fired by dispensers
  • Fixed dispensers always dispensing black creeper fireworks
  • Fixed grabbing fireworks from creative and firing it would fire a black creeper firework.

@joserobjr joserobjr added Type: bug Something isn't working Resolution: resolved The issue has been addressed or the request has been accepted labels Aug 8, 2020
@joserobjr joserobjr added this to the 1.3.1.2-PN milestone Aug 8, 2020
@joserobjr joserobjr self-assigned this Aug 8, 2020
Copy link
Member Author

@joserobjr joserobjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed

@joserobjr joserobjr merged commit 6b2b5fe into bleeding-1.3.1.2-pn Aug 8, 2020
@joserobjr joserobjr linked an issue Aug 8, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firework from dispenser only have 1 color
1 participant