Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 1.20.30 #1381

Merged
merged 10 commits into from
Sep 24, 2023
Merged

feat: 1.20.30 #1381

merged 10 commits into from
Sep 24, 2023

Conversation

CoolLoong
Copy link
Member

No description provided.

@CoolLoong CoolLoong changed the title Feature/1.20.30 feat: 1.20.30 Sep 21, 2023
@CoolLoong CoolLoong marked this pull request as draft September 21, 2023 05:11
@AzaleeX AzaleeX self-requested a review September 23, 2023 21:02
@AzaleeX AzaleeX marked this pull request as ready for review September 23, 2023 21:02
AzaleeX
AzaleeX approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@AzaleeX AzaleeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late looking at your pull request, but thanks for contributing to PowerNukkitX. ❤

@AzaleeX
Copy link
Member

AzaleeX commented Sep 23, 2023

Then it still has a problem when it tries to build maven it makes an error.
https://github.com/PowerNukkitX/PowerNukkitX/actions/runs/6257058005/job/16988838022#step:5:16749

@AzaleeX AzaleeX mentioned this pull request Sep 23, 2023
Closed
@smartcmd smartcmd marked this pull request as draft September 24, 2023 05:50
@CoolLoong CoolLoong marked this pull request as ready for review September 24, 2023 10:33
@CoolLoong CoolLoong merged commit e37007c into master Sep 24, 2023
4 checks passed
@CoolLoong CoolLoong deleted the feature/1.20.30 branch September 24, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzaleeX AzaleeX AzaleeX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CoolLoong @AzaleeX