Refactor Command Parser #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
原版的命令返回值并不是简单的boolean，而是数字 |
|
考虑过使用mojang官方的命令库吗？ https://github.com/Mojang/brigadier |
那玩意不好使 |
一开始就考虑过，但是改动太大，想兼容旧插件几乎不可能 |
|
重构命令前考虑下合并主分支？ |
|
比如说/debug已经在 #920 更改了 |
This was
linked to
issues
Jan 8, 2023
Closed
Closed
# Conflicts: # src/main/java/cn/nukkit/Player.java # src/main/java/cn/nukkit/entity/Entity.java
CoolLoong
requested review from
smartcmd and
SuperIceCN
and removed request for
smartcmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command#execute(CommandSender sender, String commandLabel, Map.Entry<String, ParamList> result, CommandLogger log)