Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative test cases for most tests #1808

Open
YuPeiHenry opened this issue Mar 12, 2019 · 1 comment
Open

Add negative test cases for most tests #1808

YuPeiHenry opened this issue Mar 12, 2019 · 1 comment
Labels
a-Testing s.ToInvestigate Requires investigation

Comments

@YuPeiHenry
Copy link
Contributor

YuPeiHenry commented Mar 12, 2019

Testing

Add negative test cases for most tests

Justification

In one of my previous PRs where I added new tests, it was not apparent that 1 of my tests was not working, until a reviewer found out from manual testing (thankfully). I was wondering if adding negative test cases to verify that a test is indeed working, is a good idea. Any thoughts? @leeyh20 @alexfjw @junkiattan

@damithc
Copy link
Member

damithc commented Mar 13, 2019

It's a good idea to have negative test cases 👍 Although, it may not necessarily catch that another test is passing no matter what. A negative test case doesn't mean the test case is expected to fail. It's a test case where we expect the SUT to react negatively e.g., throws an exception. The test case passes if the SUT reacts negatively.

@YuPeiHenry YuPeiHenry added the s.ToInvestigate Requires investigation label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Testing s.ToInvestigate Requires investigation
Projects
None yet
Development

No branches or pull requests

2 participants