Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1994 Fix CropLab CropToShape on PowerPoint 2010 #2028

Open
wants to merge 1 commit into
base: dev-release
Choose a base branch
from

Conversation

daekoon
Copy link
Contributor

@daekoon daekoon commented May 10, 2020

Fixes #1994

Outline of Solution
The CropToShape functionality on PowerPoint 2010 was not functioning properly. The cropped shape ended up being slightly off center, and the image had slightly different dimension as well. This resulted in the FT for AutoCropTest failing.

This has been fixed by implementing a multiplier to the height/width/X axis to minimize the difference caused. This fix should make the Crop functionality on PowerPoint 2010 work just like the later versions.

However, this fix does not fix the following:

@daekoon daekoon changed the base branch from master to dev-release May 10, 2020 12:17
@damithc
Copy link
Member

damithc commented May 16, 2020

Guys, this PR needs reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crop Lab FT failing on PowerPoint 2010
2 participants