Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplication of code in example in readme.md #198

Closed
AspenForester opened this issue Jun 1, 2018 · 4 comments
Closed

Duplication of code in example in readme.md #198

AspenForester opened this issue Jun 1, 2018 · 4 comments
Labels
documentation The issue is related to documentation only.

Comments

@AspenForester
Copy link

In the first example, asserting a highly available domain, the entire block of code intended for the example has been pasted in twice.
@AspenForester
Copy link
Author

Likewise, the code for configuration AssertParentChildDomains shows up again at the end of the next example.

@johlju johlju added help wanted The issue is up for grabs for anyone in the community. documentation The issue is related to documentation only. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jun 4, 2018
@johlju
Copy link
Member

johlju commented Jun 4, 2018

Label this as help wanted so that anyone in the community can run with this.

thequietman44 added a commit to thequietman44/xActiveDirectory that referenced this issue Jun 11, 2018
@thequietman44
Fixes dsccommunity#198
28027ac
@thequietman44 thequietman44 mentioned this issue Jun 12, 2018
Merged
johlju pushed a commit that referenced this issue Jun 12, 2018
@thequietman44 @johlju
Removed duplicate example config (#203)
c229b10 
- Removed duplicate example config (issues #198).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jun 12, 2018
@johlju
Copy link
Member

johlju commented Jun 12, 2018

Re-opening this as there is still a duplicate of AssertParentChildDomains.

@johlju johlju reopened this Jun 12, 2018
@johlju johlju added the help wanted The issue is up for grabs for anyone in the community. label Jun 12, 2018
@thequietman44
Copy link
Contributor

I created a new pull request with the duplicate AssertParentChildDomains removed.

@thequietman44 thequietman44 mentioned this issue Jun 13, 2018
Merged
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 13, 2018
thequietman44 added a commit to thequietman44/xActiveDirectory that referenced this issue Jun 13, 2018
@thequietman44
Updated Unreleased section with fixes for dsccommunity#190 and dsccom…
0815f91 
…munity#198
johlju pushed a commit that referenced this issue Jun 13, 2018
@thequietman44 @johlju
Remove duplicate example in README.md and fix xADUser schema version (#…
ce57669 
…206)

- Changes to xActiveDirectory
  - Changed MSFT_xADUser.schema.mof version to "1.0.0.0" to match other resources (issue #190).
  - Removed duplicated code from examples in README.md (issue #198).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 13, 2018
johlju pushed a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 19, 2019
@thequietman44 @johlju
Removed duplicate example config (dsccommunity#203)
1d0a9d1 
- Removed duplicate example config (issues dsccommunity#198).
johlju pushed a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 19, 2019
@thequietman44 @johlju
Remove duplicate example in README.md and fix xADUser schema version (d…
b125228 
…sccommunity#206)

- Changes to xActiveDirectory
  - Changed MSFT_xADUser.schema.mof version to "1.0.0.0" to match other resources (issue dsccommunity#190).
  - Removed duplicated code from examples in README.md (issue dsccommunity#198).
@johlju johlju removed the good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation The issue is related to documentation only.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johlju @AspenForester @thequietman44