Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate example config #203

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Conversation

thequietman44
Copy link
Contributor

@thequietman44 thequietman44 commented Jun 11, 2018

Removed duplicate example config.

This is my first pull request, if I missed any part of the process please educate me :)

Fixes #198


This change is Reviewable

@msftclas
Copy link

msftclas commented Jun 11, 2018

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Jun 11, 2018

Codecov Report

Merging #203 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #203   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        14     14           
  Lines      1214   1214           
  Branches     10     10           
===================================
  Hits        990    990           
  Misses      214    214           
  Partials     10     10

@johlju johlju added the needs review The pull request needs a code review. label Jun 12, 2018
@johlju
Copy link
Member

johlju commented Jun 12, 2018

:lgtm:

Normally the unreleased section of the change log should be updated. But in this case I don't feel it's necessary.


Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@johlju johlju changed the title Fixes #198 Removed duplicate example config Jun 12, 2018
@johlju johlju merged commit c229b10 into dsccommunity:dev Jun 12, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jun 12, 2018
@johlju
Copy link
Member

johlju commented Jun 12, 2018

@thequietman44 Thanks for fixing this! 😃

johlju pushed a commit to johlju/ActiveDirectoryDsc that referenced this pull request Apr 19, 2019
- Removed duplicate example config (issues dsccommunity#198).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants