Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSCResource Template Modules are missing #257

Closed
kungfoome opened this issue Apr 25, 2019 · 0 comments · Fixed by #258
Closed

DSCResource Template Modules are missing #257

kungfoome opened this issue Apr 25, 2019 · 0 comments · Fixed by #258
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@kungfoome
Copy link

The modules from https://github.com/PowerShell/DscResource.Template are missing from the repo.

Need for Get-LocalizedData
@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Apr 26, 2019
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 26, 2019
@johlju
Changes to xActiveDirectory
544b77e 
- Added localization module DscResource.LocalizationHelper containing
  the helper functions Get-LocalizedData, New-InvalidArgumentException,
  New-InvalidOperationException, New-ObjectNotFoundException, and
  New-InvalidResultException (issue dsccommunity#257).
- Added common module DscResource.Common containing the helper function
  Test-DscParameterState. The goal is that all resource common functions
  are moved to this module (functions that are or can be used by more
  than one resource) (issue dsccommunity#257).
@johlju johlju mentioned this issue Apr 26, 2019
Merged
9 tasks
johlju added a commit that referenced this issue Apr 26, 2019
@johlju
xActiveDirectory: Add common modules (#258)
c52ca33 
- Changes to xActiveDirectory
  - Added localization module DscResource.LocalizationHelper containing
    the helper functions Get-LocalizedData, New-InvalidArgumentException,
    New-InvalidOperationException, New-ObjectNotFoundException, and
    New-InvalidResultException (issue #257).
    For more information around these helper functions and localization
    in resources, see Localization section in the Style Guideline.
  - Added common module DscResource.Common containing the helper function
    Test-DscParameterState. The goal is that all resource common functions
    are moved to this module (functions that are or can be used by more
    than one resource) (issue #257).
- Changes to xADReplicationSiteLink
  - Make use of the new localization helper functions.
@kwirkykat kwirkykat removed the in progress The issue is being actively worked on by someone. label Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xActiveDirectory: Add common modules johlju/ActiveDirectoryDsc
3 participants
@kungfoome @kwirkykat @johlju