xActiveDirectory: Add common modules #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added localization module DscResource.LocalizationHelper containing the helper functions Get-LocalizedData, New-InvalidArgumentException, New-InvalidOperationException, New-ObjectNotFoundException, and New-InvalidResultException (issue dsccommunity#257). - Added common module DscResource.Common containing the helper function Test-DscParameterState. The goal is that all resource common functions are moved to this module (functions that are or can be used by more than one resource) (issue dsccommunity#257).
- Make use of the new localization helper functions.
johlju
commented
Apr 26, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## dev #258 +/- ##
====================================
+ Coverage 86% 87% +<1%
====================================
Files 19 20 +1
Lines 1741 1852 +111
Branches 11 11
====================================
+ Hits 1513 1624 +111
Misses 217 217
Partials 11 11 |
johlju
commented
Apr 26, 2019
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
the helper functions
Get-LocalizedData,New-InvalidArgumentException,New-InvalidOperationException,New-ObjectNotFoundException, andNew-InvalidResultException(issue #257).For more information around these helper functions and localization
in resources, see Localization section in the Style Guideline.
Test-DscParameterState. The goal is that all resource common functionsare moved to this module (functions that are or can be used by more
than one resource) (issue #257).
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is