Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DomainAdministratorCredential parameter in resources #269

Closed
johlju opened this issue May 4, 2019 · 2 comments · Fixed by #454
Closed

Rename DomainAdministratorCredential parameter in resources #269

johlju opened this issue May 4, 2019 · 2 comments · Fixed by #454
Assignees
@johlju
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented May 4, 2019 •
edited

The parameter DomainAdministratorCredential can be confused with that it requires actual credential that is a member of the "Domain Admins" group.
I suggest that we rename DomainAdministratorCredential to either Credential in those resources that does not actually require domain administrator credentials. That would be a BREAKING CHANGE.

Any parameter name works, but if we use Credential that parameter name is already supported by the helper function Get-ADCommonParameters. But if there are a better name, we can just add that name we come up with as an alias to the Credential parameter just like it's done for the DomainAdministratorCredential.

https://github.com/PowerShell/xActiveDirectory/blob/59113a085b920b582861a98d377ec2e0a0e91628/DSCResources/MSFT_xADCommon/MSFT_xADCommon.psm1#L504-L509
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 4, 2019
@johlju johlju changed the title Rename DomainAdministratorCredential in resource where any credential with permission works Rename DomainAdministratorCredential parameter in resources May 4, 2019
@johlju
Copy link
Member Author

johlju commented May 4, 2019

Candidates for the rename would be xADComputer and xADUser.

@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@johlju johlju added this to To do in All issues and PR's May 23, 2019
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 28, 2019
@johlju
Chanegs to ADUser
bb3e110 
- BREAKING CHANGE: Rename parameter DomainAdministrorCredential (issue dsccommunity#269)
@johlju johlju mentioned this issue Jul 28, 2019
Merged
9 tasks
@johlju
Copy link
Member Author

johlju commented Jul 28, 2019

PR for renaming parameter in ADUser in the works.

johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADComputer
3536b88 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomain
dd73e91 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task [issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomain
ce2b5d5 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task [issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomainController
5665f71 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit that referenced this issue Jul 29, 2019
@johlju
BREAKING CHANGE: ADUser: Renamed the parameter DomainAdministratorCre…
a1494c2 
…dential (#452)

- Changes to ADUser
  - BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
    to `Credential` to better indicate that it is possible to impersonate
    any credential with enough permission to perform the task (issue #269).
  - Now it correctly tests passwords when parameter DomainName is set to
   distinguished name and parameter Credential is used (issue #451).
  - Added integration tests (issue #359).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADComputer
77e2135 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomain
068cccf 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task [issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomainController
751ce62 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomainTrust
87f9a34 
- BREAKING CHANGE: Renamed the parameter `TargetDomainAdministratorCredential`
  to `TargetCredential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
@johlju johlju mentioned this issue Jul 29, 2019
Merged
9 tasks
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADComputer
d9e82d2 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomain
7dcea48 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task [issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomainController
5cc580e 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomainTrust
a51b734 
- BREAKING CHANGE: Renamed the parameter `TargetDomainAdministratorCredential`
  to `TargetCredential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADComputer
5aaa71c 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomain
c440190 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task [issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomainController
7b5b0a3 
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
  to `Credential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 29, 2019
@johlju
Changes to ADDomainTrust
bfe3495 
- BREAKING CHANGE: Renamed the parameter `TargetDomainAdministratorCredential`
  to `TargetCredential` to better indicate that it is possible to impersonate
  any credential with enough permission to perform the task (issue dsccommunity#269).
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 29, 2019
@johlju johlju self-assigned this Jul 29, 2019
All issues and PR's automation moved this from To do to Done Jul 30, 2019
johlju added a commit that referenced this issue Jul 30, 2019
@johlju
BREAKING CHANGE: ActiveDirectory: Rename parameter DomainAdministrato…
13736cf 
…rCredential (#454)

- Changes to ADComputer
  - BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
    to `Credential` to better indicate that it is possible to impersonate
    any credential with enough permission to perform the task (issue #269).
- Changes to ADDomain
  - BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
    to `Credential` to better indicate that it is possible to impersonate
    any credential with enough permission to perform the task (issue #269).
- Changes to ADDomainTrust
  - BREAKING CHANGE: Renamed the parameter `TargetDomainAdministratorCredential`
    to `TargetCredential` to better indicate that it is possible to impersonate
    any credential with enough permission to perform the task (issue #269).
- Changes to ADDomainController
  - BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
    to `Credential` to better indicate that it is possible to impersonate
    any credential with enough permission to perform the task (issue #269).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 30, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
All issues and PR's
  
Done
Milestone
No milestone
1 participant
@johlju