Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADUser: Integration tests is missing for this resource #359

Closed
johlju opened this issue Jun 7, 2019 · 0 comments · Fixed by #452
Closed

ADUser: Integration tests is missing for this resource #359

johlju opened this issue Jun 7, 2019 · 0 comments · Fixed by #452
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented Jun 7, 2019

We should add integration tests for this resource.
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Jun 7, 2019
@johlju johlju added this to To do in All issues and PR's Jun 7, 2019
@johlju johlju mentioned this issue Jul 28, 2019
Merged
9 tasks
@johlju johlju changed the title xADUser: Integration tests is missing for this resource ADUser: Integration tests is missing for this resource Jul 28, 2019
All issues and PR's automation moved this from To do to Done Jul 29, 2019
johlju added a commit that referenced this issue Jul 29, 2019
@johlju
BREAKING CHANGE: ADUser: Renamed the parameter DomainAdministratorCre…
a1494c2 
…dential (#452)

- Changes to ADUser
  - BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
    to `Credential` to better indicate that it is possible to impersonate
    any credential with enough permission to perform the task (issue #269).
  - Now it correctly tests passwords when parameter DomainName is set to
   distinguished name and parameter Credential is used (issue #451).
  - Added integration tests (issue #359).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's
  
Done
Milestone
No milestone
1 participant
@johlju