Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xActiveDirectory: Move xADCommon to xActiveDirectory.Common.psm1 #288

Closed
johlju opened this issue May 21, 2019 · 2 comments · Fixed by #320
Closed

xActiveDirectory: Move xADCommon to xActiveDirectory.Common.psm1 #288

johlju opened this issue May 21, 2019 · 2 comments · Fixed by #320
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented May 21, 2019

The helper functions in the file MSFT_xADCommon.psm1 should be moved to the xActiveDirectory.Common module. This is to align with the DscResource.Template, and have all the helper functions in one place and not keep helper functions under the DscResources folder.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels May 21, 2019
@johlju
Copy link
Member Author

johlju commented May 21, 2019 •
edited

This block should be moved into a localization string according to the style guideline https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#localization. See also already localized resources, xADComputer for example (once PR #170 is merged).

https://github.com/PowerShell/xActiveDirectory/blob/c95dddbed2eae679b082faad62513e51e332a8fa/DSCResources/MSFT_xADCommon/MSFT_xADCommon.psm1#L7-L37

@johlju johlju added this to To do in All issues and PR's May 23, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 5, 2019
@johlju
Copy link
Member Author

johlju commented Jun 5, 2019

I will be working on this one.

@johlju johlju mentioned this issue Jun 5, 2019
Merged
9 tasks
All issues and PR's automation moved this from To do to Done Jun 7, 2019
johlju added a commit that referenced this issue Jun 7, 2019
@johlju
xActiveDirectory: Move MSFT_xADCommon helper functions (#320)
44ca75e 
- Changes to xActiveDirectory
  - Move helper functions from MSFT_xADCommon to the module
    xActiveDirectory.Common ([issue #288](#288))
    - Removed helper function `Test-ADDomain` since it was not used. The
      helper function had design flaws too.
    - Now the helper function `Test-Members` outputs all the members that
      are not in desired state when verbose output is enabled.
  - Update all unit tests to latest unit test template.
@johlju johlju removed good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub in progress The issue is being actively worked on by someone. labels Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xActiveDirectory: Move MSFT_xADCommon helper functions johlju/ActiveDirectoryDsc
1 participant
@johlju