xActiveDirectory: Move MSFT_xADCommon helper functions

[johlju]

Pull Request (PR) description

• Changes to xActiveDirectory
  • Move helper functions from MSFT_xADCommon to the module
    xActiveDirectory.Common (issue xActiveDirectory: Move xADCommon to xActiveDirectory.Common.psm1 #288)
    • Removed helper function Test-ADDomain since it was not used. The
      helper function had design flaws too.

This Pull Request (PR) fixes the following issues

• Fixes xActiveDirectory: Move xADCommon to xActiveDirectory.Common.psm1 #288

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #320 into dev will decrease coverage by 1%.
The diff coverage is 86%.

@@         Coverage Diff         @@
##            dev   #320   +/-   ##
===================================
- Coverage    92%    91%   -2%     
===================================
  Files        20     19    -1     
  Lines      2307   2310    +3     
  Branches     10     10           
===================================
- Hits       2143   2115   -28     
- Misses      154    185   +31     
  Partials     10     10

[johlju]

I have no clue why Pester is reporting misses, the missing rows are hit when run locally. 🤔 For example the entire Assert-Module function is not hit.

[johlju]

Rewrote the unit test for Assert-Module just to see if there any difference. I would be surprised if it was, just want to rule that out.

[johlju]

So the tests is run, but for some reason some of the rows in the xActiveDirectory.Common does not get hit. 🤔

[johlju]

So the tests is run, but for some reason some of the rows in the xActiveDirectory.Common does not get hit.

It seems the culprit is the unit tests for xADUser. Narrowed it down so far, not sure yet what in those tests make this happen.

[johlju]

Added issue #325 to track the code coverage problem. Leaving it for now.

[johlju]

Reviewed 14 of 18 files at r1, 2 of 4 files at r2, 17 of 17 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved