Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xADComputer: Remove unnecessary cast #295

Closed
johlju opened this issue May 25, 2019 · 0 comments · Fixed by #313
Closed

xADComputer: Remove unnecessary cast #295

johlju opened this issue May 25, 2019 · 0 comments · Fixed by #313
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented May 25, 2019

We are casting the service principle names to [System.String[]] here, but it should not be necessary as they are already cast in the Get-TargetResource funciton.

https://github.com/PowerShell/xActiveDirectory/blob/43f4be93484cbb2f9c87bdf8bffacaf4ec2bad7d/DSCResources/MSFT_xADComputer/MSFT_xADComputer.psm1#L848
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels May 25, 2019
@johlju johlju added this to To do in All issues and PR's May 31, 2019
@tmeckel tmeckel mentioned this issue Jun 4, 2019
Merged
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 4, 2019
All issues and PR's automation moved this from To do to Done Jun 11, 2019
johlju pushed a commit that referenced this issue Jun 11, 2019
@tmeckel @johlju
Fix for issue 295 (#313)
f190630 
- Changes to xADComputer
  - Fix unnecessary cast in `Test-TargetResource` (Issue #295).
@johlju johlju removed good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub in progress The issue is being actively worked on by someone. labels Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for issue 295
1 participant
@johlju